ENH Allow status flags to be used generically #1856
Conversation
GuySartorelli
force-pushed
the
pulls/3/status-flags
branch
from
672dc69 to
2654029
Compare
| background-color: $color-notice; | ||
| border-color: transparent; | ||
| color: $body-color-dark; |
There was a problem hiding this comment.
These colours are fairly arbitrary but look nice as a default IMO. Only custom flags will use this styling, all of the versioned/fluent flags still use the colours they used to use.
| span.badge.status-modified { | ||
| color: $state-draft; | ||
| } | ||
|
|
||
| span.badge.status-addedtodraft { | ||
| color: $state-draft; | ||
| } | ||
|
|
||
| span.badge.status-deletedonlive, | ||
| span.badge.status-removedfromdraft { | ||
| color: #636363; | ||
| border: 1px solid #E49393; | ||
| background-color: #F2DADB; | ||
| } | ||
|
|
||
| span.badge.status-workflow-approval { | ||
| color: #56660C; | ||
| border: 1px solid #7C8816; | ||
| background-color: #DAE79A; | ||
| } |
There was a problem hiding this comment.
These were moved into the relevant modules - versioned-admin and advanced-workflow.
| // Badges with no text aren't displayed | ||
| &:empty { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
This already gets inherited from bootstrap, but it surprised me at first. Adding it here so it's explicitly intended behaviour.
Fluent relies on this for something that probably shouldn't be using status flags but I don't want to widen the scope to unpicking that right now.
| // align back button and breadcrumbs | ||
| // but specifically do NOT override badge display | ||
| *:not(.badge) { |
There was a problem hiding this comment.
Required to respect the display:none on empty badges.
GuySartorelli
force-pushed
the
pulls/3/status-flags
branch
from
2654029 to
37735fe
Compare
Take styling for versioned badges in their various places and centralise it as a more generic badge, plus ensure LeftAndMain breadcrumbs include status flags
GuySartorelli
force-pushed
the
pulls/3/status-flags
branch
from
37735fe to
fd9430a
Compare
|
Is it just me or is the text in the tag like 1 or 2 pixels too high? |
|
I wondered that too at first but that's where it's always been vertically. |
|
Yeah it probably needs to be adjusted It absolutely needs to be centered in chrome, and preferably also firefox |
Status flags are made generic in silverstripe/silverstripe-framework#11460
This PR generalises the styling for them across the board, and ensures
LeftAndMainclasses always show badges in the breadcrumbs.Styling in
CMSMainlooks like this:Custom flags look like this (but custom styling can be easily added):
Status flags in gridfields look like this:
Issue
SiteTreeinCMSMainsilverstripe-cms#2947